Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7-Eleven release #115

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

teutoburg
Copy link
Contributor

Update version files of:

  • Armazones
  • ELT
  • METIS
  • MICADO
  • MORFEO

Pushed those versions to the InstPkgs server.

This should also include the corresponding tags, but since I'm pushing this from my fork, those will probably not be included. Worst case I'll add them manually afterwards...

@teutoburg
Copy link
Contributor Author

Tests failing because there's apparently a test (that I missed) checking the version numbers in the now deprecated yaml file. This should obviously be sorted...

@hugobuddel hugobuddel merged commit a963211 into AstarVienna:dev_master Jul 12, 2023
@hugobuddel
Copy link
Collaborator

Thanks, merged! I'll merge it into master as well, and I propose that we then tag the master branch (I'll do that), even though that is not entirely correct.

This highlights another problem that I forgot to address yesterday. I find it pretty annoying that releasing a new version updates the version files, because that makes it effectively impossible to release from a specific tag. Therefore I added the -d flag to the publish script to make it possible to read from the version file instead.

I believe we are also reaching consensus that we don't really need the dev_master branch as an inbetween step. My proposal for the release process in the future is:

  1. Merge everything we want to release into master
  2. Update the versions in the yaml files
  3. Tag
  4. Publish

@teutoburg teutoburg deleted the fh/summer2023release branch July 12, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants