Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source_from_images.ipynb #469

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Update source_from_images.ipynb #469

merged 1 commit into from
Sep 16, 2024

Conversation

hugobuddel
Copy link
Collaborator

Make the plot function actually use its input. It only worked by accident.

Untested; edited from github. Living on the edge

Make the plot function actually use its input. It only worked by accident.

Untested; edited from github. Living on the edge
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I honestly forgot we even had these notebooks, thanks for spotting this!

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.99%. Comparing base (1c7ecdb) to head (56cbad2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files          64       64           
  Lines        7828     7828           
=======================================
  Hits         5949     5949           
  Misses       1879     1879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugobuddel
Copy link
Collaborator Author

Thanks to @Astrogirlanajli

@teutoburg teutoburg added the documentation Improvements or additions to documentation label Sep 13, 2024
@hugobuddel hugobuddel merged commit 57fb000 into main Sep 16, 2024
22 checks passed
@hugobuddel hugobuddel deleted the hugobuddel-patch-1 branch September 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants