Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small improvement, mostly focused on numpy #467

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Some small improvement, mostly focused on numpy #467

merged 8 commits into from
Sep 26, 2024

Conversation

teutoburg
Copy link
Contributor

No description provided.

@teutoburg
Remove useless np.all where all is just fine
f6cbfdf 
Or actually better since it can handle generator expressions...
@teutoburg
Remove unused imports
208f46d
@teutoburg
Use np.allclose(...) instead of np.all(np.isclose(...))
4b66e40
@teutoburg
Make placeholder tests xfail
9970b39 
These test cases are placeholders for functionality that's not yet
implemented (or is it?), which means the should xfail instead of just
containing a pass statement.

I guess someone just forgot these here...
@teutoburg
Revive forgotten test
926e751 
This test was indented, thus an internal function of another test and as
such not discovered by pytest. There seems to be nothing wrong with it
though, apart from some old fixtures that are now functions (not sure
which is better but that's what we have now) and a missing import.
@teutoburg
Improve implementation of chop-nod effect
a50d806
@teutoburg
Use masked arrays and proper random generators
dca1269
@teutoburg teutoburg self-assigned this Sep 7, 2024
@teutoburg teutoburg added the refactor Implementation improvement label Sep 7, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (1c7ecdb) to head (a66b971).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/electronic/noise.py 84.61% 2 Missing ⚠️
scopesim/effects/obs_strategies.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files          64       64           
  Lines        7828     7828           
=======================================
  Hits         5949     5949           
  Misses       1879     1879

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg changed the title Fh/mostlynp Some small improvement, mostly focused on numpy Sep 7, 2024
@teutoburg teutoburg marked this pull request as ready for review September 7, 2024 14:58
@teutoburg
Copy link
Contributor Author

Added @oczoske for review, I think you are knowledgeable on the Chop-Nod stuff?

@teutoburg
Copy link
Contributor Author

@hugobuddel is it fine with you to merge this? 🙂

@teutoburg teutoburg merged commit ec82f78 into main Sep 26, 2024
21 checks passed
@teutoburg teutoburg deleted the fh/mostlynp branch September 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobuddel hugobuddel hugobuddel approved these changes

@oczoske oczoske Awaiting requested review from oczoske

Assignees

@teutoburg teutoburg

Labels
refactor Implementation improvement
Projects
ScopeSim-development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teutoburg @hugobuddel @oczoske