Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADConversion effect #455

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ADConversion effect #455

wants to merge 4 commits into from

Conversation

oczoske
Copy link
Collaborator

@oczoske oczoske commented Aug 22, 2024

The ADConversion effect simulates the analogue-digital converter of a detector:

  • it applies the gain factor to convert from electrons to ADU
  • it converts to the desired output data type (e.g. uint16, as often raw data are written with BITPIX=16.

The implementation expands the existing Quantization (which imho is a misnomer).

This PR is accompanied by AstarVienna/irdb#189.

@teutoburg teutoburg added enhancement New feature or request effects Related to a ScopeSim effect labels Aug 22, 2024
@hugobuddel
Copy link
Collaborator

Renaming the Quantization to ADConversion sounds good, because that name is closer to the physical process.

However, if it also applies the gain, then the effect should always be applied, also when NDIT > 1 or when AutoExposure is used, but the quantization part should not. (Or a similar solution.)

This is a draft PR, so you probably already thought of that. I think that is what your todo: need to deal with this case more realistically statement is for, so I expect this comment is superfluous.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 28.38%. Comparing base (93a4757) to head (7d859aa).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/electronic/electrons.py 16.66% 15 Missing ⚠️
scopesim/effects/electronic/dmps.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (93a4757) and HEAD (7d859aa). Click for more details.

HEAD has 96 uploads less than BASE
Flag BASE (93a4757) HEAD (7d859aa)
98 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #455       +/-   ##
===========================================
- Coverage   75.82%   28.38%   -47.44%     
===========================================
  Files          64       62        -2     
  Lines        7804     7669      -135     
===========================================
- Hits         5917     2177     -3740     
- Misses       1887     5492     +3605     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effects Related to a ScopeSim effect enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants