Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function return_latest_github_actions_jobs_status() #449

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

teutoburg
Copy link
Contributor

This doesn't seem to be used anywhere whatsoever and I don't see why we would need it. I kept the function in my "maybe still useful" collection.

@teutoburg teutoburg self-assigned this Aug 7, 2024
@teutoburg teutoburg added the refactor Implementation improvement label Aug 7, 2024
@teutoburg teutoburg changed the title Remove unused function return_latest_github_actions_jobs_status Remove unused function return_latest_github_actions_jobs_status() Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (f995db0) to head (09bd14d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   75.80%   75.94%   +0.13%     
==========================================
  Files          64       64              
  Lines        7824     7807      -17     
==========================================
- Hits         5931     5929       -2     
+ Misses       1893     1878      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review August 7, 2024 19:26
@teutoburg
Copy link
Contributor Author

This also seems to be connected to the scopesim/server/github_actions.php file. Both were added by @astronomyk some time ago, so I'll let you decide if we still need either of them...

@astronomyk
Copy link
Collaborator

GO for it

This doesn't seem to be used anywhere whatsoever and I don't see why we
would need it. I kept the function in my "maybe still useful" collection.
@teutoburg teutoburg merged commit 293ab33 into main Aug 27, 2024
25 checks passed
@teutoburg teutoburg deleted the fh/moreutilscleanup branch August 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants