Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
SourceField
and subclasses, reworkSource
#405base: main
Are you sure you want to change the base?
Add
SourceField
and subclasses, reworkSource
#405Changes from 6 commits
50ba976
48d027f
2f9ff8c
9e5dfb7
613454d
b98401c
ca2842c
0f4058a
0ffd8da
0683306
b9e73bc
e05d3c5
12fc225
5d7f74f
c985fa4
7ac96b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 112 in scopesim/effects/spectral_efficiency.py
Codecov / codecov/patch
scopesim/effects/spectral_efficiency.py#L109-L112
Check warning on line 120 in scopesim/effects/ter_curves.py
Codecov / codecov/patch
scopesim/effects/ter_curves.py#L119-L120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this a bit risky, as we haven't checked whether
fld
has aspectra
attribute. Maybe