-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new linkchecker action #335
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #335 +/- ##
===========================================
Coverage 77.04% 77.04%
===========================================
Files 57 57
Lines 7705 7705
===========================================
Hits 5936 5936
Misses 1769 1769 ☔ View full report in Codecov by Sentry. |
Interesting, we're still getting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, now go to bed 😂
Says who 😄 I was watching https://www.twitch.tv/videos/2027847540 , a classic tetris match between the first three players who have managed to crash the game. They can play so accurately, it's crazy! For context see https://www.youtube.com/watch?v=GuJ5UuknsHU |
Yeah noticed that too. It makes sense if there are 12 jobs running simultaneously. |
All repositories (except DevOps) now use the same $ md5sum $(find . -name markdown_link_check.yml)
1c8f628159076c1ba9c407c7b0a46cb0 ./irdb/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./ScopeSim_Templates/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./speXtra/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./AnisoCADO/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./Pyckles/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./skycalc_ipy/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./ScopeSim/.github/workflows/markdown_link_check.yml
366af807eaab5c4d3f7afbb75b53cffb ./DevOps/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./HowManyBloodyPhotons/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0 ./astar-utils/.github/workflows/markdown_link_check.yml |
After merging this, I'll add it to all the other repos.
That's also why I used master, dev_master, and main, because that way we can keep the file the same between all the repos