Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeprecationWarnings for fov_grid methods #313

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

teutoburg
Copy link
Contributor

No description provided.

@teutoburg teutoburg self-assigned this Dec 18, 2023
@teutoburg teutoburg added the refactor Implementation improvement label Dec 18, 2023
Since they were commented out already, we can be sure nothing will break
by just removing them already.
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2027780) 75.17% compared to head (b344399) 75.15%.

Files Patch % Lines
scopesim/effects/apertures.py 66.66% 1 Missing ⚠️
scopesim/effects/metis_lms_trace_list.py 50.00% 1 Missing ⚠️
scopesim/effects/psfs.py 75.00% 1 Missing ⚠️
scopesim/effects/shifts.py 66.66% 1 Missing ⚠️
scopesim/effects/surface_list.py 50.00% 1 Missing ⚠️
scopesim/effects/ter_curves.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #313      +/-   ##
==============================================
- Coverage       75.17%   75.15%   -0.02%     
==============================================
  Files              59       59              
  Lines            7951     7970      +19     
==============================================
+ Hits             5977     5990      +13     
- Misses           1974     1980       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg changed the title Fh/fovgrid Add DeprecationWarnings for fov_grid methods Jan 23, 2024
@teutoburg teutoburg marked this pull request as ready for review January 23, 2024 23:37
Copy link
Collaborator

@astronomyk astronomyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All just warnings. Fine with me. Maybe I'll find the time to go down this rabbit hole

@teutoburg teutoburg merged commit c4c2264 into dev_master Jan 30, 2024
24 of 25 checks passed
@teutoburg teutoburg deleted the fh/fovgrid branch January 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants