Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more useful error message to download functions #309

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Dec 14, 2023

This adds a "did you mean X instead of Y" message when download_packages() got a package name that partially matches an existing one (but not fully). Based on a recent user's experience with ScopeSim.

@teutoburg teutoburg added the API How users interact with the software label Dec 14, 2023
@teutoburg teutoburg self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0510a49) 80.28% compared to head (ebb52a7) 80.32%.
Report is 4 commits behind head on dev_master.

Files Patch % Lines
scopesim/server/database.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #309      +/-   ##
==============================================
+ Coverage       80.28%   80.32%   +0.04%     
==============================================
  Files             147      148       +1     
  Lines           14844    14902      +58     
==============================================
+ Hits            11917    11970      +53     
- Misses           2927     2932       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review December 14, 2023 16:47
@teutoburg teutoburg merged commit 89b3872 into dev_master Dec 14, 2023
21 of 22 checks passed
@teutoburg teutoburg deleted the fh/downloaderrormsg branch December 14, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API How users interact with the software
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant