Some refactoring of z_order fuctionality #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
added
refactor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev_master #303 +/- ##
==============================================
+ Coverage 80.04% 80.07% +0.03%
==============================================
Files 145 147 +2
Lines 14771 14819 +48
==============================================
+ Hits 11823 11866 +43
- Misses 2948 2953 +5 ☔ View full report in Codecov by Sentry. |
teutoburg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a more general discussion on the topic with @astronomyk and @hugobuddel, the effects should not be ordered according to the final two digits of their z-orders, but rather the order should follow that of definition in the respective IRDB yaml files (which is the current behavior). Ultimately, the z_order might be removed completely, so it's not worth investing much if any time in any functionality related to it.
However, that discussion came after the commits found in this PR (except the final one), and everything else can still be considered and improvement, even if it's only for the docstrings, so I'm still in favor of merging. The only test that now fails is the codecov, but creating new tests for something that will likely be removed soon anyway, seems unnecessary, so I'd just ignore that.