Add ipykernel as dependency. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure whether it is necessary everywhere, but it seems to be necessary for docs, so conceivably it is also necessary for test and dev. ipykernel used to be installed automatically by ReadTheDocs but not anymore.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev_master #269 +/- ##
===========================================
Coverage 80.23% 80.23%
===========================================
Files 143 143
Lines 14808 14808
===========================================
Hits 11881 11881
Misses 2927 2927 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
|
So my reasoning for adding ipykernel also to dev and test was that if the package is not installed automatically on RTD anymore, then it is probably not a dependency of jupyter anymore or so, and thus it might also not be automatically installed by the test-runner anymore (or in the future, currently the CI tests still work fine). Plus it doesn't seem to cause problems. |
teutoburg
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether it is necessary everywhere, but it seems to be necessary for docs, so conceivably it is also necessary for test and dev.
ipykernel used to be installed automatically by ReadTheDocs but not anymore.