Apply review suggestions.

AstarNetwork · Jul 27, 2023 · 7482e7b · 7482e7b
1 parent 8d4f62e
commit 7482e7b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/pallets/xvm/src/lib.rs b/pallets/xvm/src/lib.rs
@@ -150,20 +150,20 @@ impl<T: Config> Pallet<T> {
                 used_weight: WeightInfoOf::<T>::evm_call_overheads(),
             })?;
 
-        if skip_execution {
-            return Ok(CallInfo {
-                output: vec![],
-                used_weight: WeightInfoOf::<T>::evm_call_overheads(),
-            });
-        }
-
         let value = U256::zero();
         // With overheads, less weight is available.
         let weight_limit = context
             .weight_limit
             .saturating_sub(WeightInfoOf::<T>::evm_call_overheads());
         let gas_limit = U256::from(T::GasWeightMapping::weight_to_gas(weight_limit));
 
+        if skip_execution {
+            return Ok(CallInfo {
+                output: vec![],
+                used_weight: WeightInfoOf::<T>::evm_call_overheads(),
+            });
+        }
+
         let transact_result = T::EthereumTransact::xvm_transact(
             T::AccountMapping::into_h160(source),
             CheckedEthereumTx {

diff --git a/precompiles/xvm/src/lib.rs b/precompiles/xvm/src/lib.rs
@@ -99,6 +99,8 @@ where
             Err(f) => f.used_weight,
         };
         handle.record_cost(R::GasWeightMapping::weight_to_gas(used_weight))?;
+        handle
+            .record_external_cost(Some(used_weight.ref_time()), Some(used_weight.proof_size()))?;
 
         match call_result {
             Ok(success) => {