rename to Pando #552
Merged
rename to Pando #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready for review, @Changaco. Should we remove the aspen.io website from this repo as part of this PR? |
This was referenced Mar 19, 2016
|
You're referencing |
Then we won't have it anywhere (except in the history of course), since you haven't copied it to the aspen.io repo, and it's already gone from aspen-core. |
This fixes an insufficient test for whether Aspen is already installed. The text 'found' shows up in the traceback when pkg_resources.get_distribution fails in aspen/__init__.py, and that's the way in which build.py's `import aspen` fails once the Response import in __init__.py is removed. The fix here is to delegate to pip to check whether this or that library is already installed, rather than trying to duplicate that functionality ourselves.
|
@Changaco Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to AspenWeb/salon#2 (comment).