Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish org move #551

Merged
merged 5 commits into from
Mar 17, 2016
Merged

Finish org move #551

merged 5 commits into from
Mar 17, 2016

Conversation

Changaco
Copy link
Member

Completes #547.

chadwhitacre
chadwhitacre reviewed Mar 12, 2016
View reviewed changes
setup.py
@@ -22,9 +22,7 @@
, 'Topic :: Internet :: WWW/HTTP :: WSGI :: Application'
]

setup( author = 'Gratipay, LLC'
, author_email = '[email protected]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we can get away with no author?

Either the author or the maintainer must be identified.

https://docs.python.org/2/distutils/setupscript.html#additional-meta-data

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2 setup.py sdist bdist_wheel works fine, the metadata files just have UNKNOWN for the author field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems suboptimal, because Aspen has authors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with 'Chad Whitacre et al.'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, author_email reticketed as AspenWeb/salon#12.

@Changaco
Copy link
Member Author

Email address is up, so I guess we can move forward with this now by using it in setup.py and to create an AppVeyor account.

@Changaco
Copy link
Member Author

Ready for review.

chadwhitacre added a commit that referenced this pull request Mar 17, 2016
@chadwhitacre
Merge pull request #551 from AspenWeb/finish-org-move
da8c8a6 
Finish org move
@chadwhitacre chadwhitacre merged commit da8c8a6 into master Mar 17, 2016
@chadwhitacre chadwhitacre deleted the finish-org-move branch March 17, 2016 22:47
@chadwhitacre
Copy link
Contributor

!m @Changaco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Changaco @chadwhitacre