add base URL canonicalization to algorithm #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ended up just configuring harness.client.website inline in the tests. I think that makes sense, right?
configure-aspen.py was the default for configuration_scripts, but it was possible to specify others.
I can't see that we ever use this anywhere.
Couldn't find this in use, test suite unaffected.
Don't see this being used.
As suggested in #448.
We've had this for a long time, with duplicate code downstream in Gratipay. Let's upstream it and give it a proper config knob.
Merged
pjz
added a commit
that referenced
this pull request
Jun 29, 2015
add base URL canonicalization to algorithm
|
There he is! 💃 |
|
!m @pjz :-) |
Changaco
pushed a commit
that referenced
this pull request
Mar 11, 2016
add base URL canonicalization to algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using a duplicate of this code on Gratipay for a long time. Let's upstream it.
This sets us up to also use
base_urlfor #311.Builds on #455.