Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request.fs #451

Merged
merged 1 commit into from
Jun 21, 2015
Merged

Remove request.fs #451

merged 1 commit into from
Jun 21, 2015

Conversation

chadwhitacre
Copy link
Contributor

We stopped using it in #389, but failed to in fact remove it. Closes #450.

We stopped using it in #389, but failed to in fact remove it.
Closes #450.
@chadwhitacre
Copy link
Contributor Author

Ready for review, @techtonik @pjz.

@techtonik
Copy link
Contributor

The explanation what should be used instead is still missing from
https://github.com/gratipay/aspen-python/blame/master/Changelog.md#L41
Without it I am unable to fix gratipay/inside.gratipay.com#263 (comment) so for me the issue won't gone.

@chadwhitacre
Copy link
Contributor Author

Reticketed #453.

@techtonik
Copy link
Contributor

@whit537 is it related?

@chadwhitacre
Copy link
Contributor Author

@techtonik Yes. That's where we document that Aspen uses algorithm.py, which is what you need to know to understand add_nav_current_to_context.

@techtonik
Copy link
Contributor

@whit537 I understand that this nav_current needs the filename of the current simplate to calculate navigation, but I have no idea where to get one.

@techtonik
Copy link
Contributor

Ok. The issues seem non-trivial, so let's upgrade, let it fail with new traceback and file a new bug report.

pjz added a commit that referenced this pull request Jun 21, 2015
@pjz pjz merged commit 047a1ed into master Jun 21, 2015
@pjz pjz deleted the remove-request-fs branch June 21, 2015 16:08
Changaco pushed a commit that referenced this pull request Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants