Add support for python3 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python3 bytestrings don't have a `.format()` method.
Catching two types of exceptions is obviously not a perfect solution, but it'll do for now.
python3 doesn't allow that
Changaco
force-pushed
the
python3
branch
2 times, most recently
from
243a73f to
fc6af63
Compare
To test with jython run `tox -e jython` or `TOXENV=jython python build.py test`.
|
Ready for review. |
|
Here we go ... ! 😳 |
| @@ -4,12 +4,12 @@ branches: | |||
| - master | |||
| language: python | |||
| python: | |||
| - 2.7 | |||
| - 3.5 | |||
There was a problem hiding this comment.
Why not test both? Are we dropping Python 2 support?
There was a problem hiding this comment.
Are we dropping Python 2 support?
No.
Why not test both?
We're testing all three of Python 2.7, 3.4, and 3.5, but we're using Tox instead of Travis's matrix functionality.
| """clean jython test results""" | ||
| shell('find', '.', '-name', '*.class', '-delete') | ||
| shell('rm', '-rf', 'jython-testresults.xml') | ||
|
|
There was a problem hiding this comment.
Fare thee well, Jython.
Changaco
added a commit
to AspenWeb/pando.py
that referenced
this pull request
Aug 9, 2016
That function has been removed in AspenWeb/aspen.py#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AspenWeb/pando.py#493