Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gotham theme (ref: #25) #84

Merged
merged 4 commits into from
Oct 2, 2021
Merged

added gotham theme (ref: #25) #84

merged 4 commits into from
Oct 2, 2021

Conversation

sreyan-ghosh
Copy link
Contributor

@sreyan-ghosh sreyan-ghosh commented Oct 2, 2021

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

SOLVES ISSUE #25 partially.

Changes Made

  1. File modified = styles/theme.ts
  2. Added params for gotham theme taking hex values from other repos like github-readme-stats. Here is the inspiration.

SCREENSHOTS
I have personally used this in my own README.md. Here is a preview of it in development.

image

NOTE
Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label.

@Kshitij978
Copy link
Collaborator

Kshitij978 commented Oct 2, 2021

@sreyan-ghosh Please remove the package-lock.json from the commit and add a screenshot of your theme in svg format to THEMES.md

@sreyan-ghosh
Copy link
Contributor Author

sreyan-ghosh commented Oct 2, 2021

okay, i'll let you know when i am done with that

EDIT: Instead of reverting the file back, I added another commit that changed the value back to what it was pre-commit 1.

@sreyan-ghosh
Copy link
Contributor Author

Hi @Kshitij978, I have done what had been asked. Cheers. 😃

@Kshitij978 Kshitij978 merged commit 6c5fb58 into Ashutosh00710:main Oct 2, 2021
@Ashutosh00710
Copy link
Owner

@sreyan-ghosh your theme is now available in production 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants