-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ApplicationController::onOpenURL support #14
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing! We are currently in the process of ramping up our contribution guidelines and, most importantly, contribution license agreement. I will get back to you tomorrow. |
We've committed a Contribution License Agreement for Boden at https://github.com/AshampooSystems/boden/blob/master/CLA.md (CLA). Your consent is required for us to accept your contributions. Please review the agreement and let me know whether you agree to it. There is no need to sign the agreement for now. It is effective upon your submission — and in this special case — upon your consent here since the CLA has not been online when you submitted this PR. |
Yeah the CLA looks fine for me and I agree to it! |
Great, thank you! We will review your PRs in the next days and get back to you if needed. |
Thanks a lot for adding this! Looks great! It's definitely a desired feature. We don't have contribution guidelines (wip), so here are the most important points that I think you need to know:
Please let us know whether you are willing to put more work into this. If not, we'll be keeping this open and prioritize the feature in the next sprint planning meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in the PR thread
It's fine for me to put additional work into this feature. I discovered the I closed #13 because this PR includes those changes. And I made the free space to install Android Studio so I will at least get things to compile there and I will try to implement it this weekend when I'm back home. |
Great! Let me know if we can help. Looking forward to your PR! |
For iOS this is working, unfortunately I'm having a really hard time working with Android Studio and my Android experience is very limited, so I won't be able to implement it there. |
OK, no problem. We will have a look. Thanks for your work on this! |
Is there any news about Boden ? Nothing for 8 months, is it still in dev ? |
Is there any news about Boden ? Nothing for 2 years, is it still in dev ? |
Is there any active fork of boden ? |
Based on #13
CMakeLists.txt:
For now only iOS support, but there should be a similar feature on Android. No documentation was updated and only manual testing was performed (By scanning a QR code with an
otpauth://
url and allowing it to open my app, see: http://security-totp.appspot.com).Please let me know if this is a desired feature, I can do more work if needed but couldn't really find any contributor guidelines.