Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added covenience functions #11

Merged
merged 17 commits into from
Nov 8, 2023
Merged

Added covenience functions #11

merged 17 commits into from
Nov 8, 2023

Conversation

StefanOltmann
Copy link
Member

Also did some refactoring.

@StefanOltmann
Removed duplicated literal "Empty array name"
54c0510
@StefanOltmann
Removed XMPMeta interface and merged this with the real class.
6b94904
@StefanOltmann
Removed duplicated literal "Empty property name"
b96ac57
@StefanOltmann
Default value for PropertyOptions restored
4e851f2
@StefanOltmann
@Suppress("TooManyFunctions")
218a173
@StefanOltmann
Moved private methods to better places
8d62cae
@StefanOltmann
Added convenience methods for common properties
1caa69e
@StefanOltmann
ReadXmpTest.kt & WriteXmpTest.kt use convenience methods to get unit …
be63d1b 
…test coverage on that.
@StefanOltmann
Removed sub package "impl"
65493cb
@StefanOltmann
XMPMeta.kt: Style formattings
218f1cf
@StefanOltmann
Removed XMPIterator.kt interface as there is only one implementation.
79e9505
@StefanOltmann
Merged XMPSchemaRegistry.kt & XMPSchemaRegistryImpl.kt
5350981
@StefanOltmann
Refactor XMPRDFWriter: Pass StringBuilder into the methods
6986c36
@StefanOltmann
Refactor XMPRDFWriter: Inlined write methods
e7857bc
@StefanOltmann
Refactor XMPRDFWriter: Pass XMPMeta into serialize()
c60b2f4
@StefanOltmann
Refactor XMPRDFWriter: Pass SerializeOptions into serialize()
9eb8fe5
@StefanOltmann
XMPRDFWriter is now a singleton object to avoid this instance creation
efa27d7
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 105 Code Smells

47.8% 47.8% Coverage
1.0% 1.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@StefanOltmann StefanOltmann merged commit 5258c71 into main Nov 8, 2023
2 of 3 checks passed
@StefanOltmann StefanOltmann deleted the covenience_functions branch November 8, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StefanOltmann