-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub/Monitor support #5
Pubsub/Monitor support #5
Conversation
Don't merge this PR just yet, I realized that monitors cannot be turned back into a connection, so it's drop function is actually causing an async infinite loop. I don' think there's a good reason to support Monitor in that case because once turned into one the connection cannot be returned to the pool. |
yeah that is why I said Monitor will need to be treated as if the connection never really existed to the pool. So a Get_monitor where it gets a connection without creating anything for the pool probably would be better. |
I added a factory function to the pool so that users can access the underlying client without having to go through the pool, which should cover that use case. |
So was that able to fix the monitor issue? |
Yup should be okay to merge as long as you think the changes look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good. Thank you!
No description provided.