Merge pull request #3 from Asana/sean-expose-get-promise-details

expose process.binding('util').getPromiseDetails
Asana · Jan 8, 2024 · bc56465 · bc56465
2 parents afe9b08 + e2961a4
commit bc56465
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/lib/internal/bootstrap/realm.js b/lib/internal/bootstrap/realm.js
@@ -155,7 +155,15 @@ const experimentalModuleList = new SafeSet();
           'DEP0111');
       }
       if (legacyWrapperList.has(module)) {
-        return requireBuiltin('internal/legacy/processbinding')[module]();
+        const legacy = requireBuiltin('internal/legacy/processbinding')[module]();
+        if (module === 'util') {
+          // We need getPromiseDetails and constants.kFulfilled from `internalBinding('util')`
+          return {
+            ...legacy,
+            ...internalBinding('util'),
+          };
+        }
+        return legacy;
       }
       return internalBinding(module);
     }

diff --git a/test/parallel/test-process-binding-util.js b/test/parallel/test-process-binding-util.js
@@ -7,8 +7,19 @@ const utilBinding = process.binding('util');
 assert.deepStrictEqual(
   Object.keys(utilBinding).sort(),
   [
+    'WeakReference',
+    'arrayBufferViewHasBuffer',
+    'constants',
+    'getCallerLocation',
+    'getConstructorName',
+    'getExternalValue',
+    'getOwnNonIndexProperties',
+    'getPromiseDetails',
+    'getProxyDetails',
+    'guessHandleType',
     'isAnyArrayBuffer',
     'isArrayBuffer',
+    'isArrayBufferDetached',
     'isArrayBufferView',
     'isAsyncFunction',
     'isDataView',
@@ -23,8 +34,15 @@ assert.deepStrictEqual(
     'isSetIterator',
     'isTypedArray',
     'isUint8Array',
+    'previewEntries',
+    'privateSymbols',
+    'shouldAbortOnUncaughtToggle',
+    'sleep',
+    'toUSVString',
   ]);
 
 for (const k of Object.keys(utilBinding)) {
-  assert.strictEqual(utilBinding[k], util.types[k]);
+  if (k in util.types) {
+    assert.strictEqual(utilBinding[k], util.types[k]);
+  }
 }