Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New loadout approach #658

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Casperento
Copy link
Contributor

@Casperento Casperento commented May 2, 2020

Changes proposed in this pull request:

  • fn_startLoadout.sqf refact. to use setUnitLoadout

  • Config_Loadouts.hpp reworked to support Arma 3 Unit Loadouts format

  • I have tested my changes and corrected any errors found

Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments - definitely the right direction.

Altis_Life.Altis/core/functions/fn_startLoadout.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/fn_startLoadout.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/config/Config_Loadouts.hpp Outdated Show resolved Hide resolved
@Casperento
Copy link
Contributor Author

Everything tested and working as expected

@Casperento Casperento requested a review from DomT602 May 3, 2020 22:49
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the update @Casperento. So we've been discussing the config style - specifically the naming convention. A suggestion could be to have them as cop_level_x, med_level_x. This could then mean we don't need to str(playerSide). We could do the side via a switch just add that to the format (which will later be replaced by life_util_fnc_sideToString (which is currently in #640. e.g: format["%1_level_%2",_side,_level]
This will hopefully make it clearer for users. Also - the way civilians are done is not ideal and I'd like to see if we can find another way around this. Open to any thoughts?

@Casperento
Copy link
Contributor Author

Sounds good. About the civilian classes, i'm not sure yet how can we work it. I'm opened to suggestions..

@Casperento Casperento requested a review from DomT602 May 4, 2020 22:59
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - a few more changes, we're getting very close to a solid end-state though.

Altis_Life.Altis/core/functions/fn_startLoadout.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/fn_startLoadout.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/core/functions/fn_startLoadout.sqf Outdated Show resolved Hide resolved
Altis_Life.Altis/config/Config_Loadouts.hpp Outdated Show resolved Hide resolved
@Casperento Casperento requested a review from DomT602 May 5, 2020 14:15
DomT602
DomT602 previously approved these changes May 5, 2020
Copy link
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work @Casperento. This is a good PR for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants