Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try_ when getting external asset dependency #317

Merged
merged 1 commit into from
Sep 30, 2024
Merged

try_ when getting external asset dependency #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 44 additions & 16 deletions src/mapping-v3-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,13 +1216,25 @@ export function handleExternalAssetDependencyUpdated(
FLEX_CONTRACT_EXTERNAL_ASSET_DEP_TYPES[event.params._dependencyType];

if (assetEntity.dependencyType === "ONCHAIN") {
const projextExternalAssetDependency = engineFlexContract.projectExternalAssetDependencyByIndex(
// @dev this needs a try_ in case an invalid bytecode address was set by artist when configuring the project
const projextExternalAssetDependencyResult = engineFlexContract.try_projectExternalAssetDependencyByIndex(
event.params._projectId,
event.params._index
);
assetEntity.bytecodeAddress =
projextExternalAssetDependency.bytecodeAddress;
assetEntity.data = projextExternalAssetDependency.data;
if (projextExternalAssetDependencyResult.reverted) {
log.warning(
"Failed to get external asset dependency for project {} at index {}",
[project.id, event.params._index.toString()]
);
assetEntity.bytecodeAddress = null;
assetEntity.data = null;
} else {
const projextExternalAssetDependency =
projextExternalAssetDependencyResult.value;
assetEntity.bytecodeAddress =
projextExternalAssetDependency.bytecodeAddress;
assetEntity.data = projextExternalAssetDependency.data;
}
}

assetEntity.save();
Expand Down Expand Up @@ -1287,21 +1299,37 @@ export function handleExternalAssetDependencyRemoved(
generateProjectExternalAssetDependencyId(project.id, index.toString())
);

const contractExternalAsset = engineFlexContract.projectExternalAssetDependencyByIndex(
assetEntity.project = project.id;
assetEntity.index = index;

// @dev this needs a try_ in case an invalid bytecode address was set by artist when configuring the project
const contractExternalAssetResult = engineFlexContract.try_projectExternalAssetDependencyByIndex(
project.projectId,
index
);

assetEntity.cid = contractExternalAsset.cid;
assetEntity.project = project.id;
assetEntity.index = index;
assetEntity.dependencyType =
FLEX_CONTRACT_EXTERNAL_ASSET_DEP_TYPES[
contractExternalAsset.dependencyType
];
if (assetEntity.dependencyType === "ONCHAIN") {
assetEntity.bytecodeAddress = contractExternalAsset.bytecodeAddress;
assetEntity.data = contractExternalAsset.data;
if (contractExternalAssetResult.reverted) {
log.warning(
"Failed to get external asset dependency for project {} at index {}. Values will be set to null or default.",
[project.id, index.toString()]
);
assetEntity.bytecodeAddress = null;
assetEntity.data = null;
assetEntity.cid = "";
// @dev this is a dummy value to conform to enum type. warning is logged
assetEntity.dependencyType = "IPFS";
assetEntity.bytecodeAddress = null;
assetEntity.data = null;
} else {
const contractExternalAsset = contractExternalAssetResult.value;
assetEntity.cid = contractExternalAsset.cid;
assetEntity.dependencyType =
FLEX_CONTRACT_EXTERNAL_ASSET_DEP_TYPES[
contractExternalAsset.dependencyType
];
if (assetEntity.dependencyType === "ONCHAIN") {
assetEntity.bytecodeAddress = contractExternalAsset.bytecodeAddress;
assetEntity.data = contractExternalAsset.data;
}
}
assetEntity.save();
}
Expand Down
Loading