Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for decoding from JSON into arrow, via a slightly modified version of arrow-json (https://github.com/ArroyoSystems/arrow-rs/tree/49.0.0/json) that adds support for raw json fields.
I've also started the process of moving sources away from StructDef to using native arrow datatypes. In that world, we encode raw json as an extension type with the name
arroyo.json
. The datafusion project is also thinking about how to support JSON fields (apache/datafusion#7845), so hopefully in the future we'll be able to leverage something more native.This also includes support for specifying json types in columns:
which will cause b to generate a raw json schema.
There are a few limitations to this initial PR:
BadData::Drop
, an entire batch gets dropped for a single bad recordIt's likely that our approach here will evolve, but for now this PR should work for most cases.