Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questionservice Tests and Refactoring #78

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Questionservice Tests and Refactoring #78

merged 8 commits into from
Mar 21, 2024

Conversation

didierrc
Copy link
Contributor

QuestionService improvments to include:

  • Tests of Endpoints, QuestionController and QuestionGenerator Service. Usage of Mocks to avoid Flaky Tests due to API or DB calls. Made by @didierrc
  • Documentation of QuestionGenerator Service and Refactoring to have a much clean code. Made by @Raulms29
  • Project set-up for running tests @Raulms29

@didierrc didierrc added the enhancement New feature or request label Mar 20, 2024
@didierrc didierrc linked an issue Mar 20, 2024 that may be closed by this pull request
Tests for QuestionService #71
Closed
Raulms29
Raulms29 requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Raulms29 Raulms29 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I forgot to include the execution of the tests on the build.yml. This means that the tests for the questionservice are not being automatically executed when creating a PR.
I will change it for tomorrow.

@didierrc
Copy link
Contributor Author

I have removed unused packages from QuestionService. We cannot have more dependencies than necessary

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@IyanRobles IyanRobles merged commit 45ac2c2 into master Mar 21, 2024
2 checks passed
@didierrc didierrc deleted the questionserviceTests branch March 26, 2024 16:54
@Raulms29 Raulms29 mentioned this pull request Apr 10, 2024
Closed
@didierrc didierrc mentioned this pull request Apr 10, 2024
Closed
@IyanRobles IyanRobles mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IyanRobles IyanRobles IyanRobles approved these changes

@Raulms29 Raulms29 Raulms29 approved these changes

Assignees

@didierrc didierrc

@Raulms29 Raulms29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for QuestionService
3 participants
@didierrc @IyanRobles @Raulms29