Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-rankings #105

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Test-rankings #105

merged 2 commits into from
Apr 7, 2024

Conversation

adriiglz
Copy link
Contributor

@adriiglz adriiglz commented Apr 7, 2024

Added tests for Game.jsx and removed unused code in users-service

@adriiglz adriiglz added the Enhancement ✴️ New feature or request label Apr 7, 2024
@adriiglz adriiglz requested a review from andrrsin April 7, 2024 22:35
@adriiglz adriiglz requested a review from ChristianFN2 April 7, 2024 22:35
@adriiglz adriiglz added this to the Prototype 1.0 milestone Apr 7, 2024
@adriiglz adriiglz requested a review from uo287841 April 7, 2024 22:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)
42.5% Duplication on New Code (required ≤ 30%)

See analysis details on SonarCloud

@ChristianFN2 ChristianFN2 merged commit d401c95 into develop Apr 7, 2024
1 of 2 checks passed
@adriiglz adriiglz mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrrsin andrrsin Awaiting requested review from andrrsin

@ChristianFN2 ChristianFN2 Awaiting requested review from ChristianFN2

@uo287841 uo287841 Awaiting requested review from uo287841

Assignees

@andrrsin andrrsin

@uo287841 uo287841

@ChristianFN2 ChristianFN2

Labels
Enhancement ✴️ New feature or request
Projects
None yet
Milestone
Prototype 1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adriiglz @andrrsin @uo287841 @ChristianFN2