-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConsoleUtility Refactor #53
base: develop
Are you sure you want to change the base?
Conversation
…e AskToEnterString method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AskToEnterString should have an option to enter an empty string. For example, game arguments can be empty and for the future the private key path can be empty so it doesn’t build with a key.
Yeah I don't know why I thought that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps message print methods should be shortened to PrintInfo, PrintError or to stay in C# conventions (like the Console class): WriteInfo, WriteError, etc.
I did ShowErrorMessage as it was more explicit in that it would be print to the console and would receive a user defined string to output. Write to me sounds like something that you would use if you were writing more to a stream that was not being used for simple console output. (Like a log file on the filesystem) |
Resolved |
ShowErrorMessage to me seems more like a dialog box that shows up not a console output. I think that it's quite unnecessary to include the I'd prefer |
Resolved, personally I think its better to be explicit even if it is obvious as someone might not get it but its your codebase so i'll abide by your conventions. (I did PrintErrorMessage not show as that does sound like a dialog prompt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but needs testing.
Added a check to prevent a user from entering an empty string into the AskForString method