module: small bugfix metadata.py #908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix/Improvement regarding Simplify3D meta parsing Current parsing param are not able to get filament_name and filament_type correctly. printMaterial,(%S) for filament_name is not present in Gcode (anymore?). makerBotModelMaterial,(%S) for type of filament is only changable for Export File Format= .makerbot. Even worse: the last state of the Setting is present in Gcode even if the user didnt ever used something different than Standard G-Code Export. (By default = pla) By using autoConfigurationMaterial,(%S), wich is by default one of PLA, PETG, ABS..., as filament_type we can avoid unnecessary Spoolman warnings and get a pleasurable printing history. -even with S3D ;) Signed-off-by: Silas Döring [email protected] module: metadata.py Bugfix/Improvement regarding Simplify3D meta parsing Current parsing param are not able to get filament_name and filament_type correctly. printMaterial,(%S) for filament_name is not present in Gcode (anymore?). makerBotModelMaterial,(%S) for type of filament is only changeable for Export File Format= .makerbot. Even worse: the last state of the Setting is present in Gcode even if the user didnt ever used something different than Standard G-Code Export (By default = pla). By using autoConfigurationMaterial,(%S), wich is by default one of PLA, PETG, ABS..., as filament_type we can avoid unnecessary Spoolman warnings and get a pleasurable printing history. -even with S3D ;) Signed-off-by: Silas Döring [email protected]
sdoe0
force-pushed
the
master
branch
2 times, most recently
from
1990612
to
c98cad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix/Improvement regarding Simplify3D meta parsing
Current parsing param are not able to get filament_name and filament_type correctly.
printMaterial,(%S)for filament_name is not present in Gcode (anymore?).makerBotModelMaterial,(%S)for type of filament is only changeable for Export File Format= .makerbot.Even worse: the last state of the Setting is present in Gcode even if the user didnt ever used something different than Standard G-Code Export (By default = pla).
By using
autoConfigurationMaterial,(%S), wich is by default one of PLA, PETG, ABS..., as filament_type we can avoid unnecessary Spoolman warnings and get a pleasurable printing history. -even with S3D ;)The user can create new Category called "Brand" if he wishes to get the Filament Name parsed
Signed-off-by: Silas Döring [email protected]