WLED: Fix for next version and add segment parameter #552
Conversation
Fix for upcoming WLED 0.14 release. https://discord.com/channels/473448917040758787/779395228624617512/1041238039319543908
Add 0-indexed "id" parameter to wled_control for applying settings to different segments.
Fix for upcoming WLED 0.14 release when setting presets. https://discord.com/channels/473448917040758787/779395228624617512/1041238039319543908 Signed-off-by: Cole Morris <[email protected]>
Add 0-indexed "id" parameter to wled_control for applying settings to different segments. Signed-off-by: Cole Morris <[email protected]>
Added optional ID parameter to the example macro Signed-off-by: Cole Morris <[email protected]>
corrected 3 long lines Signed-off-by: Cole Morris <[email protected]>
Signed-off-by: Cole Morris <[email protected]>
|
Thanks. One thing we would need to be sure of is that these changes don't break compatibility with previous versions of WLED. Since this PR includes multiple, unrelated changes to the WLED module its important to break those out into separate commits. One commit for the compatibility fixes, one commit for the addition of the If you are unfamiliar with git my suggestion would be to research its interactive rebase functionality. This can be used to combine/squash multiple commits into a single commit, reorder commits, and reword commit messages. A standard rebase can be used to update the pull request against master without the merge commit. After these changes are it will be necessary to use a force push to update the remote. |
The upcoming 0.14 version of WLED has some API changes that are incompatible with the current WLED_ON command. Removing the "on" call fixes this.
Additionally, I have added support for applying settings (brightness, intensity, speed) to individual WLED Segments. This enables multiple independent lights on one WLED controller. The parameter ID is zero-indexed, and if it is not provided the setting is applied to all segments on the WLED "strip".
I do wonder if ID is the best name for this parameter, as it is not self explanatory imo. It is just what WLED calls it.
I tried to rebase my commits as I initially left off the sign-off message. I am not sure if I need to do another step there as I don't know git very well.