Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Page Responsiveness #2

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Conversation

AyushiSrivastava11
Copy link
Contributor

This PR makes the landing page responsive for mobile and tablet devices.

  • Improved the mobile view responsiveness of the Home page by updating lamp component.

Fixes #1

@Arkapravo-Ghosh Arkapravo-Ghosh changed the title Page responsiveness [FIX]: Page Responsiveness Aug 21, 2024
Copy link
Member

@Arkapravo-Ghosh Arkapravo-Ghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the lamp length to change dynamically based on screen size

className="absolute right-0 bottom-[-3%]"
/>
</div>
<div className="relative min-h-screen overflow-x-hidden overflow-y-auto">
Copy link
Member

@Arkapravo-Ghosh Arkapravo-Ghosh Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better I think. Try once.

Suggested change
<div className="relative min-h-screen overflow-x-hidden overflow-y-auto">
<div className="relative min-h-screen overflow-hidden">

@Arkapravo-Ghosh
Copy link
Member

@captain-n3m0 Can you try looking into the requested changes?

@captain-n3m0
Copy link
Member

@captain-n3m0 Can you try looking into the requested changes?

Working on it.

@captain-n3m0 captain-n3m0 merged commit cb6e1bc into ArkTechOrg:main Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the temporary landing page responsive
3 participants