Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transaction-pool-service): add senders nonce and balance checks #716

Merged
merged 19 commits into from
Sep 30, 2024
Merged

fix(transaction-pool-service): add senders nonce and balance checks #716

merged 19 commits into from
Sep 30, 2024

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 27, 2024 •
edited
Loading

Summary

  • use address instead publicKey
  • add senders balance and nonce checks
  • remove applyTransaction action in senders state

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

oXtxNt9U
oXtxNt9U approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@oXtxNt9U oXtxNt9U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastijankuzner sebastijankuzner merged commit e91b157 into develop Sep 30, 2024
7 checks passed
@sebastijankuzner sebastijankuzner deleted the refactor/transaction-pool/sender branch September 30, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oXtxNt9U oXtxNt9U oXtxNt9U approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastijankuzner @oXtxNt9U