Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Electricitymeter / Cumulative device #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Allram
Copy link
Contributor

@Allram Allram commented Mar 20, 2021

Added cumulative energydevice as a separate device when choosing between Device and Mode.
Used Sensor capability and removed some of the capabilities (the ones that are left i'm using myself with an Wemos D1 Mini reading Power, temperature, status on cabinet door etc.) Just to keep them all under the same device.

Reused electricity.png from virtual_device folder.

I'm not a coder, so probably alot of "extra" code here that is not needed. But it works atleast :)

Added cumulative energydevice
@ArjanKranenburg
Copy link
Owner

Hi Vegard,

Thanks a lot for your suggestions and help.
I'm very busy at the moment, so I'll answer first. In general I'm not too keen on adding new capabilities, let alone a complete new device. But the addition of a cumulative energy capability is much requested.
So I want to have a look at this (later) in more detail and either add it to the virtual device as options during pairing or create a new app for it.

With kind regards,

Arjan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants