-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Haystack): Component Name retrieval #1291
fix(Haystack): Component Name retrieval #1291
Conversation
Should update test to use haystack 2.10 |
Well, it looks too broken for me to spend more time on this. Have a good day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey also you have to make a deep copy for inputs . and then
- Extract the inputs needed to run for the component
- Update the inputs with the default values for the inputs that are missing
Then you have to send this processed deep copy of inputs to _get_bounds_arguments.
This should be the same as Haystack pipeline._run_component method is doing.
reference : https://github.com/deepset-ai/haystack/blob/0409e5da8f862bfdbb18850b17b4bed48f060cc2/haystack/core/pipeline/pipeline.py#L45
@lambda-science we appreciate you taking a pass on this!! I can pick up from here. Thanks again for the effort! |
Thanks @jatingarg0908. I see what you mean now. The changes from 2.9 make this challenging. Probably going to try to directly instrument the component |
This issue should be resolved in |
Closing this PR out, but thanks so much for your investigations @lambda-science @jatingarg0908 ! |
Haystack 2.10 Changed internal methods.
Openinference integration of Haystack is not compatible anymore.
This MR tries to fix it with a few informations from Haystack maintainers. I'm not sure my MR fix the problems, I don't have so much time to test...
However Haystack Maintener pointed that OpenInference integration uses private methods which are subject to breaking change....
They said:
I think it should be re-factored