Allow not using signed URLs on consumers #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddowker
changed the title
| } | ||
| } | ||
|
|
||
| if creds.JSON != nil && !externalAccount { |
There was a problem hiding this comment.
what if it is an external account?
There was a problem hiding this comment.
With an external_account we now fall into the else portion which the client is prepared to work with a number of formats including external_account. It was a case that when finding the default credentials for external_account format they still filled in creds.JSON which we did not really need and made us fall into the signed url code.
michaelschiff
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the broker sends a signed URL to a consumer to allow them to retrieve fragments directly from buckets. Some of our customers do not like adding the required permissions to allow the broker to be able to sign. We had an earlier PR that was merged into the arize branch which allowed us to turn off signing on the broker side. This PR is required for the consumers to properly work with the earlier broker change to avoid using signed URLs.