Skip to content

Commit

Permalink
improve the comment about unsigned urls support
Browse files Browse the repository at this point in the history
  • Loading branch information
ddowker committed Sep 25, 2024
1 parent a580627 commit bfb1bcf
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion broker/client/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,12 @@ var (

// ARIZE specific code to end of file.
//
// To support unsigned URLs we need to be able to deal with buckets directly as a consumer and not via the signed URL.
// In OpenUnsignedFragmentURL we need to be able to open the fragment directly from the bucket. It would have
// been nice to use the backend interface in stores.go which the broker uses to access buckets. Unfortunately
// stores_test.go, which is in broker/fragment, imports broker/client so we cannot import broker/fragment here
// to avoid a cycle. Instead we will repeat a subset of store_gcs.go.
// to avoid a cycle. Instead we will repeat a subset of store_gcs.go. This makes the use support of unsigned URLs
// very gcs specific.

var SkipSignedURLs = false
var gcs = &gcsBackend{}
Expand Down

0 comments on commit bfb1bcf

Please sign in to comment.