Skip to content

Commit

Permalink
avoid signature overloading
Browse files Browse the repository at this point in the history
  • Loading branch information
ddowker committed Jun 5, 2024
1 parent 44b2ed5 commit b73ffdc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion broker/client/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (r *Reader) Read(p []byte) (n int, err error) {
if url.Scheme != "gs" {
return 0, fmt.Error("TransformSignedURLs is only supported for GCS")
}
if r.direct, err = gcs.Open(r.ctx, r.Response.FragmentUrl,
if r.direct, err = gcs.OpenWithOffset(r.ctx, r.Response.FragmentUrl,
*r.Response.Fragment, r.Request.Offset); err == nil {
n, err = r.Read(p) // Recurse to attempt read against opened |r.direct|.
}
Expand Down
2 changes: 1 addition & 1 deletion broker/fragment/store_gcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (s *GcsBackend) Open(ctx context.Context, ep *url.URL, fragment pb.Fragment
}

// Arize Open routine with offset for use with consumers and signed URLs.
func (s *GcsBackend) Open(ctx context.Context, ep *url.URL, fragment pb.Fragment, offset int64) (io.ReadCloser, error) {
func (s *GcsBackend) OpenWithOffset(ctx context.Context, ep *url.URL, fragment pb.Fragment, offset int64) (io.ReadCloser, error) {
cfg, client, _, err := s.gcsClient(ep)
if err != nil {
return nil, err
Expand Down

0 comments on commit b73ffdc

Please sign in to comment.