feat: world cli login for deployment #65

zulkhair · 2024-05-16T17:57:12Z

Closes: WORLD-1119

Overview

Adding new login feature to world cli. this feature will integrate world cli to world forge and enable user to do deployment via cli.

Brief Changelog

add new cmd command flow for login :

world cli will open browser to do authentication to world forge
after that world cli woll poll the token from world forge

Testing and Verifying

added unit test for the new function
manual testing

🎥 Video uploaded on Graphite:

coderabbitai · 2024-05-16T17:57:18Z

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2024-05-16T17:57:18Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

zulkhair · 2024-05-16T17:57:25Z

test: debug unit test #66
feat: world cli login for deployment #65 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite

codecov · 2024-05-16T18:23:56Z

Codecov Report

Attention: Patch coverage is 20.27972% with 228 lines in your changes are missing coverage. Please review.

Project coverage is 37.13%. Comparing base (ef82596) to head (5fb3599).

❗ Current head 5fb3599 differs from pull request most recent head 5fd07ae

Please upload reports for the commit 5fd07ae to get more accurate results.

Files	Patch %	Lines
tea/component/program/program.go	0.00%	106 Missing ⚠️
cmd/world/root/login.go	38.04%	51 Missing and 6 partials ⚠️
common/globalconfig/globalconfig.go	0.00%	26 Missing ⚠️
common/login/login.go	47.61%	12 Missing and 10 partials ⚠️
telemetry/sentry.go	0.00%	6 Missing ⚠️
cmd/world/cardinal/dev.go	0.00%	4 Missing and 1 partial ⚠️
common/login/login_linux.go	0.00%	4 Missing ⚠️
common/logger/logger.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #65       +/-   ##
===========================================
- Coverage   52.63%   37.13%   -15.51%     
===========================================
  Files           9       40       +31     
  Lines         720     1764     +1044     
===========================================
+ Hits          379      655      +276     
- Misses        273      982      +709     
- Partials       68      127       +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/world/root/login.go

rmrt1n · 2024-05-22T18:41:18Z

lgtm

graphite-app · 2024-05-30T04:19:59Z

Merge activity

May 30, 12:19 AM EDT: zulkhair added this pull request to the Graphite merge queue.
May 30, 12:22 AM EDT: zulkhair merged this pull request with the Graphite merge queue.

Closes: WORLD-1119 ## Overview Adding new login feature to world cli. this feature will integrate world cli to world forge and enable user to do deployment via cli. ## Brief Changelog add new cmd command flow for login : - world cli will open browser to do authentication to world forge - after that world cli woll poll the token from world forge ## Testing and Verifying - added unit test for the new function - manual testing <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/YO1Dcg4NByYdZHvKXaTq/943928a1-b536-4a82-8dac-2dd8717073cb.webm"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/YO1Dcg4NByYdZHvKXaTq/943928a1-b536-4a82-8dac-2dd8717073cb.webm"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/YO1Dcg4NByYdZHvKXaTq/943928a1-b536-4a82-8dac-2dd8717073cb.webm">Screencast from 2024-05-17 19-13-14.webm</video>

zulkhair force-pushed the daim/add_world_cli_login_for_deployment branch from cfc675a to eb09b9b Compare May 16, 2024 18:18

zulkhair force-pushed the daim/add_world_cli_login_for_deployment branch from 83b7e74 to 586a797 Compare May 17, 2024 13:02

zulkhair marked this pull request as ready for review May 17, 2024 13:04

zulkhair requested a review from rmrt1n May 17, 2024 13:04

rmrt1n reviewed May 22, 2024

View reviewed changes

cmd/world/root/login.go Show resolved Hide resolved

rmrt1n approved these changes May 22, 2024

View reviewed changes

zulkhair force-pushed the daim/add_world_cli_login_for_deployment branch 3 times, most recently from c779662 to 5bc3b04 Compare May 29, 2024 17:27

zulkhair mentioned this pull request May 30, 2024

test: debug unit test #66

Closed

zulkhair force-pushed the daim/add_world_cli_login_for_deployment branch from 5bc3b04 to 5fb3599 Compare May 30, 2024 04:13

zulkhair force-pushed the daim/add_world_cli_login_for_deployment branch from 5fb3599 to 5fd07ae Compare May 30, 2024 04:20

graphite-app bot merged commit 5fd07ae into main May 30, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: world cli login for deployment #65

feat: world cli login for deployment #65

zulkhair commented May 16, 2024 •

edited

Loading

coderabbitai bot commented May 16, 2024 •

edited

Loading

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

graphite-app bot commented May 16, 2024

zulkhair commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading

rmrt1n commented May 22, 2024

graphite-app bot commented May 30, 2024 •

edited

Loading

feat: world cli login for deployment #65

feat: world cli login for deployment #65

Conversation

zulkhair commented May 16, 2024 • edited Loading

Overview

Brief Changelog

Testing and Verifying

coderabbitai bot commented May 16, 2024 • edited Loading

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into main

zulkhair commented May 16, 2024 • edited Loading

codecov bot commented May 16, 2024 • edited Loading

Codecov Report

rmrt1n commented May 22, 2024

graphite-app bot commented May 30, 2024 • edited Loading

Merge activity

zulkhair commented May 16, 2024 •

edited

Loading

coderabbitai bot commented May 16, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

zulkhair commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading

graphite-app bot commented May 30, 2024 •

edited

Loading