Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: find world.tom on parent dir #62

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: find world.tom on parent dir #62

merged 1 commit into from
May 8, 2024

Conversation

zulkhair
Copy link
Collaborator

@zulkhair zulkhair commented Apr 29, 2024 •
edited
Loading

Closes: WORLD-1084 & WORLD-1078 & WORLD-1045

Overview

Fix find world.toml recursively on parent dir

Brief Changelog

  • load config and get root dir
  • change hardcoded chdir using rootdir
  • fix return error when file not exist

Testing and Verifying

Manually verified by running world cardinal dev

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 29, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zulkhair Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite Graphite

@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 52.72%. Comparing base (0ea5303) to head (271a9de).

❗ Current head 271a9de differs from pull request most recent head 03aa9eb. Consider uploading reports for the commit 03aa9eb to get more accurate results

Files Patch % Lines
common/config/config.go 42.85% 3 Missing and 1 partial ⚠️
common/teacmd/editor.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   52.45%   52.72%   +0.26%     
==========================================
  Files           9        9              
  Lines         692      698       +6     
==========================================
+ Hits          363      368       +5     
+ Misses        263      262       -1     
- Partials       66       68       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulkhair zulkhair marked this pull request as ready for review April 29, 2024 14:32
@zulkhair zulkhair force-pushed the daim/fix_find_world.toml_on_parent_dir branch from d15bb10 to 7ac13dd Compare April 29, 2024 15:25
jerargus
jerargus reviewed May 1, 2024
View reviewed changes
cmd/world/cardinal/dev.go Outdated Show resolved Hide resolved
@zulkhair zulkhair force-pushed the daim/fix_find_world.toml_on_parent_dir branch 2 times, most recently from a835212 to 271a9de Compare May 8, 2024 11:09
rmrt1n
rmrt1n approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@rmrt1n rmrt1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, works on my machine

@graphite-app Graphite App
Copy link

graphite-app bot commented May 8, 2024 •
edited
Loading

Merge activity

@zulkhair
fix: find world.tom on parent dir (#62)
03aa9eb 
Closes: WORLD-1084 & WORLD-1078 & WORLD-1045

## Overview

Fix find world.toml recursively on parent dir

## Brief Changelog

- load config and get root dir
- change hardcoded chdir using rootdir
- fix return error when file not exist

## Testing and Verifying

Manually verified by running `world cardinal dev`
@zulkhair zulkhair force-pushed the daim/fix_find_world.toml_on_parent_dir branch from 271a9de to 03aa9eb Compare May 8, 2024 16:34
@graphite-app graphite-app bot merged commit 03aa9eb into main May 8, 2024
5 checks passed
@rmrt1n rmrt1n deleted the daim/fix_find_world.toml_on_parent_dir branch May 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerargus jerargus jerargus left review comments

@rmrt1n rmrt1n rmrt1n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zulkhair @rmrt1n @jerargus