Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: init markdown-lint and resolve linter issues #50

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

heronimus
Copy link
Contributor

@heronimus heronimus commented Mar 25, 2024

Closes: WORLD-983

Overview

Add markdown linter

Brief Changelog

  • https://github.com/marketplace/actions/markdown-lint
  • fix markdown linter issues
  • customize markdown linter config:
    • increase MD013/line-length default line length from 80 (too short), to 250 (median "looks good" line length in our docs)
    • add MD033/no-inline-html necessary allowed HTML element

Testing and Verifying

  • CI passed
  • Lint error annotation detected on changed code:
    image
    image

Copy link

coderabbitai bot commented Mar 25, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.23%. Comparing base (ad580c8) to head (71d8783).

❗ Current head 71d8783 differs from pull request most recent head 221db5d. Consider uploading reports for the commit 221db5d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files           8        8           
  Lines         448      448           
=======================================
  Hits          234      234           
  Misses        185      185           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

Closes: WORLD-983

## Overview

Add markdown linter

## Brief Changelog

- https://github.com/marketplace/actions/markdown-lint
- fix markdown linter issues
- customize markdown linter config:
  - increase `MD013/line-length` default line length from 80 (too short), to 250 (median "looks good" line length in our docs)
  - add `MD033/no-inline-html` necessary allowed HTML element

## Testing and Verifying

- CI passed
- Lint error annotation detected on changed code:
![image](https://github.com/Argus-Labs/world-engine/assets/29672212/01907dea-6de6-413e-aac8-d92e9734c00b)
![image](https://github.com/Argus-Labs/world-engine/assets/29672212/3664194a-5ee8-4e68-be79-c6784a63501f)
@smsunarto smsunarto force-pushed the heronimus/WORLD-983-markdown-lint-fix branch from 71d8783 to 221db5d Compare March 25, 2024 20:58
@graphite-app graphite-app bot merged commit 221db5d into main Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants