-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: init markdown-lint and resolve linter issues #50
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 52.23% 52.23%
=======================================
Files 8 8
Lines 448 448
=======================================
Hits 234 234
Misses 185 185
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Merge activity
|
Closes: WORLD-983 ## Overview Add markdown linter ## Brief Changelog - https://github.com/marketplace/actions/markdown-lint - fix markdown linter issues - customize markdown linter config: - increase `MD013/line-length` default line length from 80 (too short), to 250 (median "looks good" line length in our docs) - add `MD033/no-inline-html` necessary allowed HTML element ## Testing and Verifying - CI passed - Lint error annotation detected on changed code: ![image](https://github.com/Argus-Labs/world-engine/assets/29672212/01907dea-6de6-413e-aac8-d92e9734c00b) ![image](https://github.com/Argus-Labs/world-engine/assets/29672212/3664194a-5ee8-4e68-be79-c6784a63501f)
71d8783
to
221db5d
Compare
Closes: WORLD-983
Overview
Add markdown linter
Brief Changelog
MD013/line-length
default line length from 80 (too short), to 250 (median "looks good" line length in our docs)MD033/no-inline-html
necessary allowed HTML elementTesting and Verifying