feat: add hot reloading on dev mode #33
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
WalkthroughThis update introduces hot reloading to the World CLI's development mode, streamlining the development process by automatically refreshing the code upon file changes. By incorporating the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 47.97% 47.97%
=======================================
Files 8 8
Lines 469 469
=======================================
Hits 225 225
Misses 229 229
Partials 15 15 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (2)
- cmd/world/cardinal/dev.go (3 hunks)
- sttt (1 hunks)
Files skipped from review due to trivial changes (1)
- sttt
Additional comments: 2
cmd/world/cardinal/dev.go (2)
- 16-16: The import of
github.com/gravityblast/fresh/runneris correctly added to enable hot reloading functionality. Ensure that thefreshlibrary version used is compatible with the project's Go version and other dependencies to avoid conflicts.- 73-81: The removal of the
runCardinalfunction and its error handling, as mentioned in the PR summary, shifts the execution responsibility to thefreshrunner. This is a significant architectural change. Ensure that all functionalities and error handling previously covered byrunCardinalare adequately addressed or are no longer necessary with the new hot reloading setup.
zulkhair
force-pushed
the
daim/world-757-add_hot_reloading_on_dev_mode
branch
from
5697e54
to
04487c0
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (1)
- cmd/world/cardinal/dev.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/world/cardinal/dev.go
zulkhair
force-pushed
the
daim/world-757-add_hot_reloading_on_dev_mode
branch
from
04487c0
to
94b6df6
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (1)
- cmd/world/cardinal/dev.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/world/cardinal/dev.go
|
Holy cow, this is great! |
zulkhair
force-pushed
the
daim/world-757-add_hot_reloading_on_dev_mode
branch
2 times, most recently
from
c95b668
to
66b2b6f
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (1)
- cmd/world/cardinal/dev.go (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/world/cardinal/dev.go
zulkhair
force-pushed
the
daim/world-757-add_hot_reloading_on_dev_mode
branch
from
66b2b6f
to
bcb810b
Compare
Merge activity
|
Closes: WORLD-757 ## Overview Adding hot reload on `world cardinal dev` command ## Brief Changelog - Modify a way to run cardinal from using plain `go run` to wrapped using `fresh` library ## Testing and Verifying - Run the binary in linux(ubuntu) - Run the binary in windows <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Enhanced development environment setup for better efficiency. - **Chores** - Integrated a subproject update to ensure the latest features and fixes are included. - **New Features** - Added import for `github.com/gravityblast/fresh/runner`. - **Bug Fixes** - Removed the `runCardinal` function call and related error handling. - Changed directory to "cardinal" and set environment variable "RUNNER_IGNORED" before starting `runner.Start()`. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
zulkhair
force-pushed
the
daim/world-757-add_hot_reloading_on_dev_mode
branch
from
bcb810b
to
125ed24
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sum
Files selected for processing (1)
- cmd/world/cardinal/dev.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/world/cardinal/dev.go
Closes: WORLD-757
Overview
Adding hot reload on
world cardinal devcommandBrief Changelog
go runto wrapped usingfreshlibraryTesting and Verifying
Summary by CodeRabbit
github.com/gravityblast/fresh/runner.runCardinalfunction call and related error handling.runner.Start().