-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: world.toml config file and set namespace #16
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
===========================================
+ Coverage 23.52% 57.14% +33.61%
===========================================
Files 3 4 +1
Lines 51 105 +54
===========================================
+ Hits 12 60 +48
- Misses 39 43 +4
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it might be kinda nice to have toml headers for the specific resource you're configuring. something like:
[evm]
DA_AUTH_TOKEN=blah
BLAH=BLAH
[cardinal]
CARDINAL_NAMESPACE=BLAH
yeah lets do this, we might actually need this because we might have multiple different cardinal game projects in the same repo that needs different configs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. can we throw an example.toml in the root? i see its in the starter-template but would be nice to have here just for reference, and even testing
Closes: #WORLD-574
What is the purpose of the change
Make it possible to drive world-cli via a configuration file. world-cli checks for configuration files in the following order:
--config=/path/to/some/file
In the current iteration of this code, key/value pairs in the toml files are interpreted as environment variables and passed directly to the docker-compose command.
This starter-game-template-pr: Argus-Labs/starter-game-template#31 includes a sample config file.
Testing and Verifying
There are unit tests to verify the loading and parsing of