fix lint

cmd/world/root/login.go

@@ -39,7 +39,6 @@ func getLoginCmd() *cobra.Command {
 		Short: "Authenticate using an access token",
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			logger.SetDebugMode(cmd)
-			var err error
 
 			// TODO : it's not necessary to check existing login token
 			// Check existing login
@@ -64,7 +63,7 @@ func getLoginCmd() *cobra.Command {
 			// 	logger.ErrorE(eris.Wrap(err, "failed to get access token"))
 			// }
 
-			err = loginOnBrowser(cmd.Context())
+			err := loginOnBrowser(cmd.Context())
 			if err != nil {
 				return eris.Wrap(err, "failed to login")
 			}

cmd/world/root/root_test.go

@@ -16,6 +16,7 @@ import (
 
 	"github.com/spf13/cobra"
 	tassert "github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"gotest.tools/v3/assert"
 
 	"pkg.world.dev/world-cli/cmd/world/cardinal"
@@ -279,7 +280,7 @@ func TestGenerateTokenName(t *testing.T) {
 	name, err := generateTokenName()
 
 	// Ensure no error was returned
-	tassert.NoError(t, err)
+	require.NoError(t, err)
 
 	// Ensure the name follows the expected pattern
 	tassert.Contains(t, name, "cli_")
@@ -367,12 +368,12 @@ func TestPollForAccessToken(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			handler := http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 				if test.retryAfterHeader != "" {
 					w.Header().Set("Retry-After", test.retryAfterHeader)
 				}
 				w.WriteHeader(test.statusCode)
-				w.Write([]byte(test.responseBody))
+				w.Write([]byte(test.responseBody)) //nolint:errcheck // Ignore error for test
 			})
 
 			server := httptest.NewServer(handler)
@@ -384,9 +385,9 @@ func TestPollForAccessToken(t *testing.T) {
 			response, err := pollForAccessToken(ctx, server.URL)
 
 			if test.expectError {
-				tassert.Error(t, err)
+				require.Error(t, err)
 			} else {
-				tassert.NoError(t, err)
+				require.NoError(t, err)
 				tassert.Equal(t, test.expectedResponse, response)
 			}
 		})

common/globalconfig/globalconfig.go

@@ -6,12 +6,13 @@ import (
 	"path/filepath"
 
 	"github.com/rotisserie/eris"
+
 	"pkg.world.dev/world-cli/common/logger"
 )
 
 const (
 	configDir          = ".worldcli"
-	credentialFileName = "credential.json"
+	credentialFileName = "credential.json" //nolint:gosec // This is not a credential
 )
 
 type Credential struct {

common/logger/logger.go

@@ -73,7 +73,7 @@ func Error(args ...interface{}) {
 
 // Error function
 func ErrorE(err error) {
-	log.Error().Timestamp().Err(err)
+	log.Error().Timestamp().Err(err).Msg(err.Error())
 }
 
 // Errorln function

common/login/login_test.go

@@ -9,34 +9,35 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestDecryptAccessToken(t *testing.T) {
 	// Initialize encryption
 	enc, err := NewEncryption()
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	// Generate a remote key pair
 	remoteCurve := ecdh.P256()
 	remotePrivateKey, err := remoteCurve.GenerateKey(rand.Reader)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	remotePublicKey := remotePrivateKey.PublicKey()
 
 	// Sample access token and nonce
 	accessToken := "sample_access_token"
 	nonce := make([]byte, 12)
 	_, err = rand.Read(nonce)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	// Encrypt the access token
 	secret, err := remotePrivateKey.ECDH(enc.publicKey)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	block, err := aes.NewCipher(secret)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	aesgcm, err := cipher.NewGCM(block)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	ciphertext := aesgcm.Seal(nil, nonce, []byte(accessToken), nil)
 
@@ -49,6 +50,6 @@ func TestDecryptAccessToken(t *testing.T) {
 	decryptedAccessToken, err := enc.DecryptAccessToken(hexAccessToken, hexPublicKey, hexNonce)
 
 	// Assertions
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	assert.Equal(t, accessToken, decryptedAccessToken)
 }

telemetry/sentry.go

@@ -35,7 +35,8 @@ func (h SentryHook) Run(_ *zerolog.Event, level zerolog.Level, msg string) {
 
 // Levels returns the log levels that this hook should be triggered for
 func (h SentryHook) Levels() []zerolog.Level {
-	return []zerolog.Level{zerolog.ErrorLevel, zerolog.FatalLevel, zerolog.DebugLevel, zerolog.PanicLevel, zerolog.WarnLevel}
+	return []zerolog.Level{zerolog.ErrorLevel, zerolog.FatalLevel, zerolog.DebugLevel,
+		zerolog.PanicLevel, zerolog.WarnLevel}
 }
 
 // SentryInit initialize sentry