Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(starter-game-template): Include replace directive when copying starter-game-template and use .gitignore when copying files #9

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(starter-game-template): Include replace directive when copying starter-game-template and use .gitignore when copying files #9

merged 2 commits into from
Sep 8, 2023

Conversation

jerargus
Copy link
Contributor

@jerargus jerargus commented Sep 7, 2023 •
edited
Loading

Closes WORLD-95

Fix the mage copy command. Cardinal requires some replace directives that were not copied over from the source project.

Use the .gitignore file to limit what files are copied instead of maintaining a custom list of rules.

pyrofolium
pyrofolium approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@pyrofolium pyrofolium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerargus jerargus merged commit 1949f50 into main Sep 8, 2023
6 checks passed
@namrapatel namrapatel deleted the jer/include-replace-directives branch November 1, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrofolium pyrofolium pyrofolium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerargus @pyrofolium