Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starter-game-template) added pretty logging when run under 'mage dev' #8

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

pyrofolium
Copy link
Contributor

image

@pyrofolium pyrofolium changed the title added pretty logging when run under 'mage dev' feat(starter-game-template) added pretty logging when run under 'mage dev' Sep 5, 2023
@pyrofolium
Copy link
Contributor Author

What's the policy for merging here? Github gave me access without a review and the PR title is not linted like cardinal.

@pyrofolium
Copy link
Contributor Author

This one is currently blocked @jerargus requested that I move this Option into cardinal for re-use. So that one now has a pending review that must pass before I modify this PR to work with the other one.

@pyrofolium
Copy link
Contributor Author

Should be ready just need a final review.

@pyrofolium pyrofolium merged commit 798474d into main Sep 6, 2023
6 checks passed
@namrapatel namrapatel deleted the brian/car-197/add_pretty_logging_dev_mode branch November 1, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants