Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nakama): use tx receipts to automatically verify p… #6

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

jerargus
Copy link
Contributor

…ersona tag creation

Closes CAR-117

  • Add a personaTagVerifier struct that uses tx receipts to verify whether a persona tag registration was accepted or rejected.
  • refactor the personaTagStorageObj code into a dedicated source file
  • Update the making of signed payloads and the 'show-persona' endpoint to check with cardinal to see if a persona tag has been accepted or rejected. This code path won't normally be used because the personaTagVerified system will do this automatically and asynchronously.

Testing:
mage test will run persona tag creation unit tests against nakama and cardinal.

@namrapatel namrapatel changed the title feat(starter-game-templte): use tx receipts to automatically verify p… feat(nakama): use tx receipts to automatically verify p… Sep 5, 2023
@pyrofolium
Copy link
Contributor

weird I don't see this on graphite for some reason.

@pyrofolium
Copy link
Contributor

A bit convoluted what's going on here but LGTM.

@pyrofolium pyrofolium self-requested a review September 7, 2023 01:10
Copy link
Contributor

@pyrofolium pyrofolium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern here is a bit convoluted but LGTM.

@jerargus jerargus merged commit 928210b into main Sep 7, 2023
3 checks passed
@namrapatel namrapatel deleted the jer/use-tx-hash-to-verify-persona-tag-registration branch November 1, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants