feat(starter-game-template): Make template use new swagger routes and various other changes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
pyrofolium
commented
Sep 19, 2023
jerargus
suggested changes
Sep 19, 2023
jerargus
suggested changes
Sep 20, 2023
jerargus
approved these changes
Sep 20, 2023
| } | ||
| if resp.StatusCode != 200 { | ||
| body, _ := io.ReadAll(resp.Body) | ||
| return logError(logger, "bad status code: %w: %s", resp.Status, body) |
There was a problem hiding this comment.
Suggested change
| return logError(logger, "bad status code: %w: %s", resp.Status, body) | |
| return logError(logger, "bad status code: %s: %v", resp.Status, body) |
There was a problem hiding this comment.
whoops I'll make another pr for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes#: World-316
Change log
Sorry this one is kind of big. Will comment to make things clear:
DockerFileanddocker-compose.ymlto trigger cardinal starting up in debug mode underdocker-composemage startDebugthat does everythingmage startdoes except cardinal is running in debug mode. (note you will have to attach a debugger to port 4000 for the server to run)mage startDebugthen execute the run configuration in goland. Now you can debug cardinal with break points.Testing: