Small waf improvement steps #907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tabs and no trailing spaces.
libs/temporal/wscript only uses APPNAME for convenience for test purposes. It can just be a local variable. Temporal is not so independent that it can be used as a separate waf project with its own APPNAME.
Try to make it a bit more clear what is going on with class and def for i18n commands. It was confusing that we first defined i18n classes in the beginning of the wscript file, and then replaced them with "plain" functions with the same name at the end. pyflakes also didn't like it. It seemed magic. The i18n functionality easily broke if trying to touch that. It deserves an explanation to make it maintainable ... and some cleanup. Simple functions in the top level wscript file are generally exposed as custom waf commands. The command will have the same name as the function and will get a plain Context. But that simple method doesn't work for these i18n commands. They have to be declared in a different way with a custom BuildContext, as seen and described in the comment. The name of the BuildContext classes doesn't matter, so we change the name to avoid the name collision and to give a hint how they actually just are contexts for the commands - they are not the command itself. We also place the classes next to the corresponding functions so it is more obvious that they are related.
Rename the worker functions to make it clear that their name in this case isn't magic. These functions "are not" the waf commands. It is the custom build context class definitions that define the i18n commands ... which will invoke these top level worker functions which in turn invoke the others recursively. The bare printing of the build environment in the top level i18n command seems to be old debug code that safely can be removed.
|
Please ignore "wscript: make APPNAME a local variable in temporal wscript" for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.