Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upload qr modal #437

Merged
merged 3 commits into from
Jul 12, 2024
Merged

refactor: upload qr modal #437

merged 3 commits into from
Jul 12, 2024

Conversation

patricio0312rev
Copy link
Contributor

[send] refactor qr handling files

Summary

  • Logic and components to upload a QR have been moved to their own file.
    The code in Send page has been refactored.

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 1.13.0 milestone Jul 12, 2024
@ItsANameToo ItsANameToo merged commit 878cf67 into develop Jul 12, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/upload-qr-modal branch July 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@patricio0312rev @ItsANameToo