Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add chevrons to onboarding screens #435

Merged
merged 13 commits into from
Jul 11, 2024

Conversation

ItsANameToo
Copy link
Contributor

@ItsANameToo ItsANameToo commented Jul 10, 2024

Summary

https://app.clickup.com/t/86du2czk8

TODO:

  • properly handle interval clearing (or refactor completely)
  • ensure progressbar moves with the slides instead of being its own thing

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 1.12.0 milestone Jul 10, 2024
@ItsANameToo ItsANameToo modified the milestones: 1.12.0, 1.13.0 Jul 10, 2024
@ItsANameToo ItsANameToo changed the base branch from rc-1.12.0 to develop July 10, 2024 12:28
@patricio0312rev patricio0312rev marked this pull request as ready for review July 10, 2024 14:07
@ItsANameToo ItsANameToo merged commit 3b95d01 into develop Jul 11, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/onboarding-chevrons branch July 11, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants